Skip to content
This repository was archived by the owner on Jan 10, 2025. It is now read-only.

Conversation

nayan-dhabarde
Copy link

Performing AndroidSupportInjection.inject method in onCreate of Fragment Life Cycle can lead to inconsistencies when the fragment is reattached which leads to the issue in which androidInjector() in the fragment returns null.

It is recommended in the Dagger documentation to perform it in onAttach() as mentioned in When to Inject

@google-cla
Copy link

google-cla bot commented Mar 3, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@nayan-dhabarde
Copy link
Author

@googlebot I signed it!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant